Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "PerformanceProgramFeedback" ADD COLUMN "updatedAt" TIMESTAMP(3);
1 change: 1 addition & 0 deletions prisma/schema.prisma
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ model PerformanceProgramFeedback {
givenBy User @relation("FeedbackGivenBy", fields: [givenByUserId], references: [id])
files File[]
createdAt DateTime @default(now())
updatedAt DateTime?
}

model CommissionBonus {
Expand Down
128 changes: 112 additions & 16 deletions src/components/PerformanceProgramPanel.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { memo, useState } from 'react'
import { Eye, File as FileIcon, MessageSquare, X } from 'lucide-react'
import { Button } from '@/components/ui/button'
import { Textarea } from '@/components/ui/textarea'
import {
Tooltip,
TooltipContent,
Expand All @@ -11,9 +12,11 @@ import { createToast } from 'vercel-toast'
import { useServerFn } from '@tanstack/react-start'
import {
resolvePerformanceProgram,
updateProgramFeedback,
getProofFileUrl,
deleteProofFile,
} from '@/routes/employee.$employeeId'
import { useSession } from '@/lib/auth-client'
import { PerformanceProgramChecklistItem } from './PerformanceProgramChecklistItem'
import { InlineProofImage, isImageFile } from './InlineProofImage'
import { FeedbackInput } from './FeedbackInput'
Expand Down Expand Up @@ -121,8 +124,17 @@ export function PerformanceProgramPanel({
reportingChain = [],
}: PerformanceProgramPanelProps) {
const [isResolving, setIsResolving] = useState(false)
const [editingFeedbackId, setEditingFeedbackId] = useState<string | null>(
null,
)
const [editingText, setEditingText] = useState('')
const [isSavingEdit, setIsSavingEdit] = useState(false)

const { data: session } = useSession()
const currentUserId = session?.user?.id

const resolveProgram = useServerFn(resolvePerformanceProgram)
const editFeedback = useServerFn(updateProgramFeedback)
const getFileUrl = useServerFn(getProofFileUrl)
const deleteFile = useServerFn(deleteProofFile)

Expand Down Expand Up @@ -188,6 +200,41 @@ export function PerformanceProgramPanel({
}
}

const handleStartEdit = (feedbackId: string, currentText: string) => {
setEditingFeedbackId(feedbackId)
setEditingText(currentText)
}

const handleCancelEdit = () => {
setEditingFeedbackId(null)
setEditingText('')
}

const handleSaveEdit = async () => {
if (!editingFeedbackId || !editingText.trim()) return

setIsSavingEdit(true)
try {
await editFeedback({
data: {
feedbackId: editingFeedbackId,
feedback: editingText.trim(),
},
})
createToast('Feedback updated', { timeout: 3000 })
setEditingFeedbackId(null)
setEditingText('')
onUpdate()
} catch (error) {
createToast(
error instanceof Error ? error.message : 'Failed to update feedback',
{ timeout: 3000 },
)
} finally {
setIsSavingEdit(false)
}
}

if (!program) {
return null
}
Expand Down Expand Up @@ -289,6 +336,10 @@ export function PerformanceProgramPanel({
const nonImageFiles = feedback.files.filter(
(f) => !isImageFile(f.fileName, f.mimeType),
)
const canEdit =
program.status === 'ACTIVE' &&
feedback.givenBy.id === currentUserId
const isEditing = editingFeedbackId === feedback.id
return (
<div
key={feedback.id}
Expand All @@ -302,24 +353,69 @@ export function PerformanceProgramPanel({
<span className="shrink-0 text-sm whitespace-nowrap text-gray-500">
{new Date(feedback.createdAt).toLocaleDateString()}
</span>
{nonImageFiles.length > 0 && (
<div className="ml-auto flex shrink-0 items-center gap-1">
{nonImageFiles.map((file) => (
<FeedbackFileChip
key={file.id}
file={file}
isActive={program.status === 'ACTIVE'}
onDownload={handleDownloadFile}
onDelete={handleDeleteFile}
/>
))}
</div>
{feedback.updatedAt && (
<span className="shrink-0 text-xs text-gray-400 italic">
(edited)
</span>
)}
<div className="ml-auto flex shrink-0 items-center gap-1">
{nonImageFiles.map((file) => (
<FeedbackFileChip
key={file.id}
file={file}
isActive={program.status === 'ACTIVE'}
onDownload={handleDownloadFile}
onDelete={handleDeleteFile}
/>
))}
{canEdit && !isEditing && (
<button
type="button"
className="shrink-0 text-xs text-gray-400 hover:text-gray-600"
onClick={() =>
handleStartEdit(feedback.id, feedback.feedback)
}
>
Edit
</button>
)}
</div>
</div>
{feedback.feedback && (
<p className="text-sm whitespace-pre-line text-gray-700">
{feedback.feedback}
</p>
{isEditing ? (
<div className="space-y-1.5">
<Textarea
value={editingText}
onChange={(e) => setEditingText(e.target.value)}
rows={3}
className="w-full resize-none text-sm"
autoFocus
/>
<div className="flex items-center gap-1.5">
<Button
size="sm"
className="h-7 gap-1 px-2 text-xs"
onClick={handleSaveEdit}
disabled={isSavingEdit || !editingText.trim()}
>
{isSavingEdit ? 'Saving...' : 'Save'}
</Button>
<Button
variant="ghost"
size="sm"
className="h-7 px-2 text-xs"
onClick={handleCancelEdit}
disabled={isSavingEdit}
>
Cancel
</Button>
</div>
</div>
) : (
feedback.feedback && (
<p className="text-sm whitespace-pre-line text-gray-700">
{feedback.feedback}
</p>
)
)}
{imageFiles.length > 0 && (
<div className="flex flex-wrap gap-2">
Expand Down
34 changes: 34 additions & 0 deletions src/routes/employee.$employeeId.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,40 @@ export const addProgramFeedback = createInternalFn({
return feedback
})

export const updateProgramFeedback = createInternalFn({
method: 'POST',
})
.inputValidator((d: { feedbackId: string; feedback: string }) => d)
.handler(async ({ data, context }) => {
const existing = await prisma.performanceProgramFeedback.findUnique({
where: { id: data.feedbackId },
include: { program: true },
})

if (!existing) {
throw new Error('Feedback not found')
}

if (existing.program.status !== 'ACTIVE') {
throw new Error('Cannot edit feedback on a resolved program')
}

// Only the author can edit their own feedback
if (existing.givenByUserId !== context.user.id) {
throw new Error('Unauthorized')
}

const updated = await prisma.performanceProgramFeedback.update({
where: { id: data.feedbackId },
data: {
feedback: data.feedback,
updatedAt: new Date(),
},
})

return updated
})

export const resolvePerformanceProgram = createInternalFn({
method: 'POST',
})
Expand Down