refactor(server): Drop redundant equals/hashCode from data classes#499
Merged
marandaneto merged 1 commit intoPostHog:mainfrom Apr 29, 2026
Merged
Conversation
Member
|
@dustinbyrne do you remember why you added custom equals and hashcodes if dataclasses generate them? |
Member
|
@saunter511 can you generate a changeset? https://github.com/PostHog/posthog-android/blob/main/RELEASING.md |
Contributor
|
This is either an artifact from before the server-side SDK had distinct animal sniffer rules or a copy-paste from core to this library. I see no reason we should keep it 👍 |
marandaneto
approved these changes
Apr 29, 2026
saunter511
force-pushed
the
refactor/drop-redundant-equals-hashcode
branch
from
585116f to
fabaa08
Compare
FeatureFlagCacheEntry and FeatureFlagCacheKey are data classes. Kotlin auto-generates equals() and hashCode(). The manual overrides duplicated this logic and required manual updates whenever fields were added (see commits 472cc44 and 74b4f49 in FeatureFlagCacheEntry). Removing them reduces the maintenance surface and makes the code more Kotlin idiomatic.
saunter511
force-pushed
the
refactor/drop-redundant-equals-hashcode
branch
from
fabaa08 to
4a7f73f
Compare
Contributor
Author
|
@marandaneto Added the changeset. |
marandaneto
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
FeatureFlagCacheEntry and FeatureFlagCacheKey are data classes. Kotlin auto-generates equals() and hashCode().
The manual overrides duplicated this logic and required manual updates whenever fields were added (see commits 472cc44 and 74b4f49 in FeatureFlagCacheEntry).
Removing them reduces the maintenance surface and makes the code more Kotlin idiomatic.
💚 How did you test it?
📝 Checklist
If releasing new changes
pnpm changesetto generate a changeset file