fix: no-op setup without api key#503
Draft
marandaneto wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
posthog-android Compliance ReportDate: 2026-04-30 10:42:49 UTC
|
| Test | Status | Duration |
|---|---|---|
| Request Payload.Request With Person Properties Device Id | ❌ | 278ms |
Failures
request_payload.request_with_person_properties_device_id
404, message='Not Found', url='http://sdk-adapter:8080/get_feature_flag'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Setup currently continued initializing after the API key trimmed to an empty string. Java callers could also pass a null Android API key and hit SDK init unexpectedly.
This changes null API keys to trim to an empty string and makes core/stateless setup return before initialization when the key is empty after trimming. Android setup skips Android-specific configuration for invalid keys.
💚 How did you test it?
./gradlew :posthog:test --tests "com.posthog.PostHogConfigTest" --tests "com.posthog.PostHogStatelessTest" --tests "com.posthog.PostHogTest"./gradlew :posthog-android:testDebugUnitTest --tests "com.posthog.android.PostHogAndroidConfigTest" --tests "com.posthog.android.PostHogAndroidConfigJavaTest" --tests "com.posthog.android.PostHogAndroidTest"make checkFormat./gradlew :posthog:apiCheck :posthog-android:apiCheck📝 Checklist
If releasing new changes