Skip to content

feat(error-tracking): support custom properties#133

Closed
MunifTanjim wants to merge 1 commit intoPostHog:masterfrom
MunifTanjim:improve-error-tracking
Closed

feat(error-tracking): support custom properties#133
MunifTanjim wants to merge 1 commit intoPostHog:masterfrom
MunifTanjim:improve-error-tracking

Conversation

@MunifTanjim
Copy link

@MunifTanjim MunifTanjim commented Nov 15, 2025

image

Copy link
Contributor

@orian orian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test checkin that marshaled message didn't change? Also, we need to add proper changelog entry, it's a breaking change

@MunifTanjim MunifTanjim force-pushed the improve-error-tracking branch from d1f781c to 658d359 Compare November 16, 2025 10:52
@MunifTanjim
Copy link
Author

Can you add a test checkin that marshaled message didn't change?

I'm not sure how to write that test. Is there any similar existing tests? The whole existing test suite is passing with the change tho.

Also, we need to add proper changelog entry, it's a breaking change

Should I modify CHANGELOG.md file in this PR? Or would that be written before releasing?

@jonathanlab
Copy link

Thanks a lot for raising the issue + your PR!

We're going to continue work on this feature in this PR. It also adds tests + support for passing properties to NewDefaultException. Would love your eyes on it as well to see if it's what you're looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants