feat(error-tracking): support custom properties#133
Closed
MunifTanjim wants to merge 1 commit intoPostHog:masterfrom
Closed
feat(error-tracking): support custom properties#133MunifTanjim wants to merge 1 commit intoPostHog:masterfrom
MunifTanjim wants to merge 1 commit intoPostHog:masterfrom
Conversation
orian
reviewed
Nov 15, 2025
Contributor
orian
left a comment
There was a problem hiding this comment.
Can you add a test checkin that marshaled message didn't change? Also, we need to add proper changelog entry, it's a breaking change
d1f781c to
658d359
Compare
Author
I'm not sure how to write that test. Is there any similar existing tests? The whole existing test suite is passing with the change tho.
Should I modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.