Skip to content

fix(surveys): include dismissal responses on iOS#580

Merged
lucasheriques merged 1 commit intomainfrom
fix/survey-dismissal-responses
Apr 27, 2026
Merged

fix(surveys): include dismissal responses on iOS#580
lucasheriques merged 1 commit intomainfrom
fix/survey-dismissal-responses

Conversation

@lucasheriques
Copy link
Copy Markdown
Contributor

@lucasheriques lucasheriques commented Apr 27, 2026

Summary

  • include in-progress survey responses on survey dismissed events
  • add $survey_partially_completed for dismissed surveys
  • reuse the same response-property builder for dismissal and submission events
  • add a patch changeset for release tracking

Companion PRs

How did you test this change?

  • swift build
  • added survey dismissal event coverage in PostHogSurveyEventsTest
  • swift test --filter PostHogSurveyEventsTest is currently blocked by existing unrelated compile failures in PostHogSessionManagerTest.swift in this clone

@lucasheriques lucasheriques requested a review from a team as a code owner April 27, 2026 15:38
@github-actions
Copy link
Copy Markdown
Contributor

posthog-ios Compliance Report

Date: 2026-04-27 15:48:45 UTC
Duration: 850ms

⚠️ Some Tests Failed

0/1 tests passed, 1 failed


Feature_Flags Tests

⚠️ 0/1 tests passed, 1 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 130ms

Failures

request_payload.request_with_person_properties_device_id

404, message='Not Found', url='http://host.docker.internal:8080/get_feature_flag'

@lucasheriques lucasheriques merged commit cc2b23b into main Apr 27, 2026
33 checks passed
@lucasheriques lucasheriques deleted the fix/survey-dismissal-responses branch April 27, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants