Skip to content

fix: acknowledge oversized dropped events #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marandaneto merged 1 commit into from
Apr 30, 2026
+7 −0
Merged

fix: acknowledge oversized dropped events #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .sampo/changesets/oversized-event-flush-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
pypi/posthog: patch
---

Prevent flush from hanging after dropping oversized queued events.
1 change: 1 addition & 0 deletions posthog/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def next(self):
self.log.error(
"Item exceeds 900kib limit, dropping. (%s)", str(item)
)
queue.task_done()
continue
items.append(item)
total_size += item_size
Expand Down
1 change: 1 addition & 0 deletions posthog/test/test_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def test_dropping_oversize_msg(self) -> None:
next = consumer.next()
self.assertEqual(next, [])
self.assertTrue(q.empty())
self.assertEqual(q.unfinished_tasks, 0)

def test_upload(self) -> None:
q = Queue()
Expand Down
Loading