fix: content-type not set with custom domain and accept */*
#4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is an attempt to fix #3391. About 6 spec tests break because according to this fix (and even before it), they are a bug. For the solution, I have added a Looking for feedback on this. |
taimoorzaeem
changed the title
*/**/*
taimoorzaeem
added
the
breaking change
BREAKING CHANGE Adds a `*/*` to available media type mapping. Now, the server responds with available media type when `Accept: */*`. Signed-off-by: Taimoor Zaeem <taimoorzaeem@gmail.com>
taimoorzaeem
force-pushed
the
fix/content-type/3391
branch
from
3bef99b to
83c6bcf
Compare
taimoorzaeem
changed the title
*/**/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Closes #3391.