Skip to content

FEAT: Alter colour of update icon and and filter#532

Open
LinkeD365 wants to merge 4 commits intodevfrom
LinkeD365/issue524
Open

FEAT: Alter colour of update icon and and filter#532
LinkeD365 wants to merge 4 commits intodevfrom
LinkeD365/issue524

Conversation

@LinkeD365
Copy link
Copy Markdown
Contributor

@LinkeD365 LinkeD365 commented Apr 27, 2026

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Follow the guidelines from the CONTRIBUTING.md.
  • Mention the bug or the feature number the PR will be targeting.
  • Test the change in your own code. (Compile and run)
  • Resolve all GH Copilot comments.

Copilot AI review requested due to automatic review settings April 27, 2026 12:29
@github-actions
Copy link
Copy Markdown

Bundle Size Report 📦

Bundle Size
Main Process 957.21 KB
Renderer JS 545.79 KB
Renderer CSS 96.65 KB
Total 1.56 MB

Bundle Analysis Reports

The detailed bundle analysis reports are available in the workflow artifacts:

  • 📊 Main Process: stats-main.html
  • 📊 Renderer Process: stats-renderer.html

Download the artifacts from the workflow run to view interactive visualizations.


Bundle size tracking is now active! This helps prevent bundle bloat.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the renderer UI to better surface “update available” state for installed tools by introducing an “Update Available” filter and adjusting the update indicator styling/placement in the tools sidebar.

Changes:

  • Add an “Update Available” checkbox filter to the Installed tools filter dropdown and wire it into sidebar filtering logic.
  • Restyle/reposition the per-tool update indicator (badge) in the tools list layout.
  • Introduce a development-only mock response for tool update checks (currently randomized).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/renderer/styles.scss Adds checkbox styling for the new filter; adjusts update badge styling and some layout/transition formatting.
src/renderer/modules/toolsSidebarManagement.ts Implements the new “Update Available” filter and moves the update badge into a header-right stack near the overflow menu button.
src/renderer/index.html Adds the new “Update Available” checkbox to the Installed tools filter dropdown; minor HTML formatting tweaks.
src/main/index.ts Adds a development-only mock for CHECK_TOOL_UPDATES (currently random).

Comment thread src/main/index.ts Outdated
Comment thread src/renderer/styles.scss Outdated
Comment thread src/renderer/modules/toolsSidebarManagement.ts Outdated
Comment thread src/renderer/modules/toolsSidebarManagement.ts Outdated
@LinkeD365 LinkeD365 changed the title Alter colour of update icon and and filter FEAT: Alter colour of update icon and and filter Apr 27, 2026
@LinkeD365
Copy link
Copy Markdown
Contributor Author

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread in commit 30dbc67:

  1. accent-color fallback (styles.scss:2600): Changed fallback from #0078d4 to #6a00ff to match the app's Power Platform purple accent.
  2. Update badge (toolsSidebarManagement.ts:297 & 331): Replaced the bare triangle character in a <span> with a proper <img> tag using the existing update.svg icon (theme-aware: light/dark variants). Added an updateIconPath variable following the same pattern as moreIconPath.
  3. .tool-update-badge CSS: Updated from font-based properties (font-size, color, line-height) to image sizing (width: 16px; height: 16px) to match the <img> element.

…icator

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 27, 2026 12:53
@github-actions
Copy link
Copy Markdown

Bundle Size Report 📦

Bundle Size
Main Process 957.21 KB
Renderer JS 545.84 KB
Renderer CSS 96.65 KB
Total 1.56 MB

Bundle Analysis Reports

The detailed bundle analysis reports are available in the workflow artifacts:

  • 📊 Main Process: stats-main.html
  • 📊 Renderer Process: stats-renderer.html

Download the artifacts from the workflow run to view interactive visualizations.


Bundle size tracking is now active! This helps prevent bundle bloat.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Comment thread src/renderer/modules/toolsSidebarManagement.ts
Comment thread src/main/index.ts Outdated
Comment on lines +801 to +805
// DEV MOCK: randomly flag ~50% of tools as having an update available
if (process.env.NODE_ENV === "development") {
const hasMockUpdate = Math.random() < 0.5;
if (hasMockUpdate) {
return { hasUpdate: true, latestVersion: "99.0.0" };
Copy link

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a random DEV-only mock for CHECK_TOOL_UPDATES, which changes behavior unrelated to the PR’s stated UI changes and can make the update badge/filter hard to manually validate (results change on every invocation). Consider removing this from the PR, or making it deterministic/opt-in (e.g., behind an explicit env flag or based on a stable hash of toolId).

Copilot uses AI. Check for mistakes.
Comment thread src/renderer/modules/toolsSidebarManagement.ts Outdated
Comment thread src/renderer/modules/toolsSidebarManagement.ts Outdated
Comment thread src/renderer/modules/toolsSidebarManagement.ts Outdated
@LinkeD365
Copy link
Copy Markdown
Contributor Author

@copilot apply changes based on the comments in this thread

… doc comment, remove dev mock

Agent-Logs-Url: https://github.com/PowerPlatformToolBox/desktop-app/sessions/82a20789-a4d1-4ba9-b4a0-1ccd6012a19d

Co-authored-by: LinkeD365 <43988771+LinkeD365@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 27, 2026

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread in commit 5d987b6:

  1. Unused variable (toolsSidebarManagement.ts:214): Removed the updateIconPath declaration from the tool-list render loop (the one at line 527 in the context menu is separate and correctly used).
  2. Accessibility (lines 297 & 331): Added role="img" and aria-label="Update available" to both update badge <span> elements in compact and standard modes.
  3. Doc comment (clearInstalledToolsDropdownFilters): Updated to document that it also clears the "Update Available" checkbox.
  4. DEV mock (index.ts): Removed the random Math.random() mock entirely so CHECK_TOOL_UPDATES always delegates to the real toolManager.checkForUpdates(toolId).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants