-
Notifications
You must be signed in to change notification settings - Fork 98
Update dotnet deps + run formatting on all relevant files + some fixes #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It looks like the build isn't working in CI for this PR |
It builds fine on my Windows machine. 🤔 Seems GitHub actions builds on Ubuntu 22.04. Can it (Linux) even target net472? Why the Windows Server 2022 build fails I don't know. |
It builds fine on my (Windows) machine as well, but I just pulled in your most recent changes and it's (still) not building on the server. We only build on windows, and then we use that build to test Windows PowerShell on Windows and PowerShell Core on Windows, Mac and Ubuntu. Could you try opening up a new PR with a subset of these changes? It may help to have a smaller set of changes |
Could we get more output on what/where it fails? |
@adityapatwardhan's change resolved the build issue (just an incorrect file name), but it looks like many of the tests are failing with the same error: Error parsing server metadata: Could not load file or assembly |
This PR is just a suggestion on some housekeeping I think is due.
Feel free to close it or ask for changes.
PR Summary
dotnet-outdated
.alexr00.formatallfilesinworkspace
.Install-PSResource
of PSResourceGet in setupReleaseTools, not the aliasInstall-Module
./
vs\
) in build scripts.PR Context
Why?
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.