Bugfix: Uninstall-PSResource should delete subdirectories without Access Denied error on OneDrive #1860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamnavi
requested review from
SydneyhSmith,
adityapatwardhan and
alerickson
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anamnavi
force-pushed
the
onedrive-uninstall
branch
from
1e8408b to
5f111e4
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 3 commits
October 24, 2025 15:14
…ithout access denied error and add error handling
anamnavi
force-pushed
the
onedrive-uninstall
branch
from
5f111e4 to
aa85c9e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alerickson
reviewed
Oct 28, 2025
| if (ex.Message.Contains("The directory is not empty") && psVersion.StartsWith("5")) | ||
| { | ||
| // there is a known bug with WindowsPowerShell and OneDrive based module paths, where .NET Directory.Delete() will throw a 'The directory is not empty.' error. | ||
| throw new Exception(string.Format("Cannot uninstall module with OneDrive based path on WindowsPowerShell due to .NET issue. Try installing and uninstalling using PowerShellCore if using OneDrive."), ex); |
There was a problem hiding this comment.
Suggested change
| throw new Exception(string.Format("Cannot uninstall module with OneDrive based path on WindowsPowerShell due to .NET issue. Try installing and uninstalling using PowerShellCore if using OneDrive."), ex); | |
| throw new Exception(string.Format("Cannot uninstall module with OneDrive based path on Windows PowerShell due to .NET issue. Try installing and uninstalling using PowerShell 7+ if using OneDrive."), ex); |
alerickson
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when uninstalling a module that was installed to a OneDrive module path, it deletes the module files successfully but not the subdirectories and an error is thrown. The subdirectories need to also have their file attribute set to
FileAttributes.Normalto allow for deletion.Tested manually on PS7.
PR Summary
PR Context
Resolves #1793
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.