-
Notifications
You must be signed in to change notification settings - Fork 130
Draft of PSModulePath behavior in PS7 #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good, but some details still need fleshing out
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
||
### Starting PowerShell 7 from Windows PowerShell | ||
|
||
The PowerShell 7 startup covers this case and should just work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these need to be explicit; what changes are made (if any) to env:PSModulePath
in these cases? Are there differences between platforms (Windows vs Non-Windows)
1-Draft/RFCxxxx-PSModulePath.md
Outdated
Change would be to use `$env:PSModulePath`, but prefix with `User` modules path + `System` modules path + | ||
`$PSHOME` modules path if any of those paths are not already there. | ||
|
||
`Windows` modules path will already be there along with any additional paths added by the user or applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to reflect the comparison with PSModulePath in User registry
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
||
### Starting Windows PowerShell from PowerShell 7 | ||
|
||
```powershell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove indentation
1-Draft/RFCxxxx-PSModulePath.md
Outdated
|
||
### Starting Windows PowerShell from PowerShell 7 | ||
|
||
```powershell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unindent these code blocks. The MD code fences are being treated as code because of the indentation. This causes a rendering problem
Fix examples to be consistent.
@PowerShell/powershell-committee has accepted this RFC, and it's been implemented in PS 7.0 |
Define behavior of PSModulePath in PS7 when starting and when starting Windows PowerShell