Skip to content

Draft of PSModulePath behavior in PS7 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2020

Conversation

SteveL-MSFT
Copy link
Member

Define behavior of PSModulePath in PS7 when starting and when starting Windows PowerShell

Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good, but some details still need fleshing out


### Starting PowerShell 7 from Windows PowerShell

The PowerShell 7 startup covers this case and should just work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be explicit; what changes are made (if any) to env:PSModulePath in these cases? Are there differences between platforms (Windows vs Non-Windows)

@SteveL-MSFT SteveL-MSFT added this to the 7.0-Consider milestone Nov 25, 2019
Change would be to use `$env:PSModulePath`, but prefix with `User` modules path + `System` modules path +
`$PSHOME` modules path if any of those paths are not already there.

`Windows` modules path will already be there along with any additional paths added by the user or applications.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to reflect the comparison with PSModulePath in User registry


### Starting Windows PowerShell from PowerShell 7

```powershell
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove indentation


### Starting Windows PowerShell from PowerShell 7

```powershell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unindent these code blocks. The MD code fences are being treated as code because of the indentation. This causes a rendering problem

Fix examples to be consistent.
@joeyaiello
Copy link
Contributor

joeyaiello commented Feb 5, 2020

@PowerShell/powershell-committee has accepted this RFC, and it's been implemented in PS 7.0

@joeyaiello joeyaiello merged commit a4f08ae into PowerShell:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants