Add whitelist for custom headers that will be forwarded to the micros…#27
Open
witschko wants to merge 9 commits intoPoweredLocal:masterfrom
Open
Add whitelist for custom headers that will be forwarded to the micros…#27witschko wants to merge 9 commits intoPoweredLocal:masterfrom
witschko wants to merge 9 commits intoPoweredLocal:masterfrom
Conversation
…ervices. A new environment variable X_HEADER_WHITELIST can be filled with a JSON object that contains custom HTTP headers.
|
It's not better to forward Header value receive from Client ? Like this. // Check if there are whitelisted custom headers
$whiteList = config('gateway.headers', '');
if ($whiteList != '') {
foreach ($whiteList as $key) {
if ($request->headers->has($key)) {
$headers[$key] = $request->headers->get($key);
}
}
}And for header white list config i have this. // Header white list to forward to micro services
'headers' => [
'TEST',
]So if client put i request header |
dusterio
reviewed
Jun 25, 2019
|
|
||
| foreach ($whiteList as $key => $value) { | ||
| $headers[$key] = $value; | ||
| } |
Contributor
There was a problem hiding this comment.
hmm if I understand correctly, this is not really a white list (a list of allowed headers to pass through) but a pre-defined list of headers to pass? then it should be called something else, eg extra headers
Contributor
Author
There was a problem hiding this comment.
Ok...you're right. I think then we should go with the suggestion of @MrDarkSkil
Contributor
Author
There was a problem hiding this comment.
I have updated the PR to match the real whitelist functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ervices. A new environment variable X_HEADER_WHITELIST can be filled with a JSON object that contains custom HTTP headers.
This references #24.