Skip to content

Fix outside the bounds error and vertical line at last value for lineplot#28

Open
damianpowell wants to merge 1 commit intoPrateekKumarSingh:masterfrom
damianpowell:#18-lineplot-bounds
Open

Fix outside the bounds error and vertical line at last value for lineplot#28
damianpowell wants to merge 1 commit intoPrateekKumarSingh:masterfrom
damianpowell:#18-lineplot-bounds

Conversation

@damianpowell
Copy link

Fixes issue #18.

OperationStopped: /Path/To/Modules/Graphical/1.0.2/src/Get-LinePlot.ps1:33:21
Line |
  33 |                      $Array[$j,$i] = $Line # add line
     |                      ~~~~~~~~~~~~~~~~~~~~~
     | Index was outside the bounds of the array.

Also Fixes a suprious vertical line that is produced on the final value. Old behaviour:

 106┤                                                 ▐ 
 105┤                ██                               ▐ 
 104┤          █    ▐ ▐                               ▐ 
 103┤         ▐▐ █  ▐ ▐                               ▐ 
 102┤         ▐ █▐  ▐  █                              ▐ 
 101┤       █ █  ▐  ▐  ▐                              ▐ 
 100┤      ▐▐▐   ▐  ▐  ▐        █   ██                ▐ 
  99┤      ▐▐▐   ▐  ▐  ▐       █▐  ▐ ▐                ▐ 
  98┤      ▐ █   ▐  █  ▐      ▐ ▐  ▐ ▐                ▐ 
  97┤      ▐      ██   ▐      ▐ ▐  ▐ ▐                ▐ 
  96┤      ▐            █ ██  ▐  █ █ ▐  █             ▐ 
  95┤      ▐            ▐█ ▐  ▐  ▐▐  ▐ ▐▐█            ▐ 
  94┤ █    █               ▐  ▐   █  ▐ ▐ ▐            ▐ 
  93┤█▐   ▐                ▐  ▐       ██  █           ▐ 
  92┤  █  ▐                ▐  ▐           ▐           ▐ 
  91┤  ▐  ▐                 █ ▐           ▐           ▐ 
  90┤  ▐  ▐                 ▐ █           ▐           ▐ 
  89┤  ▐  █                 ▐▐             █    █     ▐ 
  88┤  ▐ ▐                  ▐▐             ▐███▐▐     ▐ 
  87┤  ▐ █                  ▐▐                ▐▐ █    ▐ 
  86┤   █                    █                ▐▐ ▐    ▐ 
  85┤                                          █  █   ▐ 
  84┤                                             ▐█ █▐ 
  83┤                                              ▐▐▐█ 
  82┤                                               █ ▐ 
    └─────────┬─────────┬─────────┬─────────┬─────────┬ 
             10        20        30        40        50 

New behaviour:

 106┤                                                   
 105┤                ██                                 
 104┤          █    ▐ ▐                                 
 103┤         ▐▐ █  ▐ ▐                                 
 102┤         ▐ █▐  ▐  █                                
 101┤       █ █  ▐  ▐  ▐                                
 100┤      ▐▐▐   ▐  ▐  ▐        █   ██                  
  99┤      ▐▐▐   ▐  ▐  ▐       █▐  ▐ ▐                  
  98┤      ▐ █   ▐  █  ▐      ▐ ▐  ▐ ▐                  
  97┤      ▐      ██   ▐      ▐ ▐  ▐ ▐                  
  96┤      ▐            █ ██  ▐  █ █ ▐  █               
  95┤      ▐            ▐█ ▐  ▐  ▐▐  ▐ ▐▐█              
  94┤ █    █               ▐  ▐   █  ▐ ▐ ▐              
  93┤█▐   ▐                ▐  ▐       ██  █             
  92┤  █  ▐                ▐  ▐           ▐             
  91┤  ▐  ▐                 █ ▐           ▐             
  90┤  ▐  ▐                 ▐ █           ▐             
  89┤  ▐  █                 ▐▐             █    █       
  88┤  ▐ ▐                  ▐▐             ▐███▐▐       
  87┤  ▐ █                  ▐▐                ▐▐ █      
  86┤   █                    █                ▐▐ ▐      
  85┤                                          █  █     
  84┤                                             ▐█ █  
  83┤                                              ▐▐▐█ 
  82┤                                               █   
    └─────────┬─────────┬─────────┬─────────┬─────────┬ 
             10        20        30        40        50 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant