Add a result cache to get_publisher_variable to store processed XML data #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeezer
pushed a commit
that referenced
this pull request
Dec 30, 2024
Collaborator
|
Really good! Merged as-is, only with a new commit message. Curious to know why an attribute on a function might be superior to a module-level variable, such as our Thanks for YASU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
get_publisher_variablemultiple times from Python redoes the possibly expensive work of running the XSL report and parsing it. This saves the results of that work for use in future calls to the function.On APEX Calculus, this and #2341 reduce the build time of APEX from 20m+ to ~2.5m.