WeBWorK: support for 2.19 #2601
Conversation
|
A note for @rbeezer: at first glance, some code changes may seem unnecessary. There are such things in there that will make it smooth to bring in some remaining features from the Tacoma branch (use local PG files and use the standalone PG renderer web service). The code overlaps and I wanted to take the Tacoma branch and whittle it down, not reinvent things only to then have to reinvent back, when those new features come back. Ask away if you have questions about them but if you can see how the code might relate to those other looming features, that is probably the explanation. |
Alex-Jordan
force-pushed
the
ww-219-support
branch
from
3bdea5a to
5784973
Compare
|
Following @ascholer 's reply to a -dev post of mine, this now has a small correction to where css files are pulled from for the embedded WW exercises. |
Alex-Jordan
force-pushed
the
ww-219-support
branch
from
5784973 to
1877910
Compare
|
OK, now back tot he original commit hash this PR started with, plus an additional commit for the change I described. |
|
OK, my testing is complete. Note to self: maybe CSS themes need a regeneration. (No need to comment, it'll happen or it won't, and is not critical.) I will ping @bnmnetp off-list. Post here if you know anything, I'm not seeing anything here from him. as instructed, I won't merge until he checks off. If his work requires changes, please do a follow-on commit, not a force-push. I do not want to test again, and I can meld into existing commit if that is called for. |
|
And an afterthought. Would this have been even cleaner if we had done |
|
Pinged @bnmnetp off-list, and he replied off-list. He says first pass looks good, and I should merge - he'll introduce slowly (Lethbridge first) and check more carefully as he goes. |
|
Merged with no changes. What's next? |
|
Thanks! Next major item up will be using local .pg files in the external folder. There might be one or two small things first to make that go smooth. |
|
So so soooo excited for local .pg files! |
3 participants
This will let PreTeXt be used with a 2.19 webwork2 server. Please note that in my testing, I needed to view HTML output via a web server as opposed to opening a local file with a web browser. I'm unsure if this has to do with WW 2.19 or the particular WW 2.19 server we are using.
@bnmnetp Please test and give me feedback about how well this works for Runestone. I assume you will know what to do, but of course this is not in the CLI. So you will need to build in whatever way is right. Take a look at
examples/webwork/sample-chapter/publisher/publication.xml. You will then want to open the parallelpublication-academy.xmland edit thewebworkelement. To change things so you are using an actual 2.19 WW server, setserver="https://webwork-dev.aimath.org". I believe that is all you need do before you build. However, when you build, make sure to build a new representations file before building HTML.My builds of HTML output are:
In my testing of those, things are working. But @bnmnetp, you will want to also test Runestone records answers and loads them back.
For @rbeezer, in addition to testing functionality of HTML, I studied diffs. I built everything (representations, HTML, latex) five ways:
The only diffs I found are either inconsequential, expected, or they are actual improvements that come from PG 2.19 giving us better PTX.
Please test as usual, but also please wait for feedback from Brad before doing anything serious. I may have to make edits and push them here.
Once this is processed, I can upgrade the main AIM WW server to 2.19. And the same with the Runestone workhorse server. There will still be more things to come from #2336.