Pr1 #2
Open
Pr1 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename gammascan.json to .gammascan.json
| String count; | ||
| public void process() { | ||
| SecureRandom secureRandom = new SecureRandom(); | ||
| System.runFinalizersOnExit(true); |
There was a problem hiding this comment.
I detect that this code is problematic. According to the Bad practice (BAD_PRACTICE), Dm: Method invokes dangerous method runFinalizersOnExit (DM_RUN_FINALIZERS_ON_EXIT).
Never call System.runFinalizersOnExit or Runtime.runFinalizersOnExit for any reason: they are among the most dangerous methods in the Java libraries. -- Joshua Bloch
|
|
||
|
|
||
| public void demo(String name, String surName,String count,String preeti) { | ||
| String surName = surName; |
There was a problem hiding this comment.
I detect that this code is problematic. According to the Dodgy code (STYLE), SA: Self assignment of local variable (SA_LOCAL_SELF_ASSIGNMENT).
This method contains a self assignment of a local variable; e.g.
Such assignments are useless, and may indicate a logic error or typo.
Owner
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.