make RedisLockManager picklable for ray/dask compat
#18018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
force-pushed
the
redis-locking-serialization
branch
from
09fbec2 to
7bb6ed4
Compare
zzstoatzz
changed the title
RedisLockManager picklable for ray/dask compat
zzstoatzz
force-pushed
the
redis-locking-serialization
branch
2 times, most recently
from
3ced681 to
b2802e4
Compare
remove unused code typing one more
zzstoatzz
force-pushed
the
redis-locking-serialization
branch
from
b2802e4 to
6108ee2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for pickling in the RedisLockManager so that it can be used with Ray/Dask. It does so by refactoring client initialization into a dedicated _init_clients method, adding getstate/setstate to exclude live connections and reset locks, and extending the test suite to verify both synchronous and asynchronous lock behavior post-unpickle.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/integrations/prefect-redis/tests/test_locking.py | Adds tests to ensure correct reinitialization of RedisLockManager clients and lock behavior after pickling/unpickling. |
| src/integrations/prefect-redis/prefect_redis/locking.py | Refactors client initialization into _init_clients, implements getstate/setstate, and updates lock acquisition logic for asynchronous operations. |
Comments suppressed due to low confidence (1)
src/integrations/prefect-redis/prefect_redis/locking.py:147
- [nitpick] Consider renaming 'aacquire_lock' to 'acquire_lock_async' for improved clarity and consistency with typical asynchronous method naming conventions.
async def aacquire_lock(
desertaxle
reviewed
May 11, 2025
update inaccurate comment
zzstoatzz
force-pushed
the
redis-locking-serialization
branch
from
de0d83e to
d8c44c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #18017 where unpicklable
_thread.lockinRedisLockManagercaused issues when used with Ray/Daskthis PR:
__init__: Now calls a newself._init_clients()method to instantiateself.clientandself.async_clientimmediately_init_clients(): private method containing the client instantiation logic__getstate__: pickle only connection parameters (host, port, etc.), excluding live clients and_locks.__setstate__: after restoring state, now callsself._init_clients()to ensure fresh client connections are established, resetsself._locks = {}.