Merged
Conversation
追加:
- tests/paintRegistry.test.ts 新規 (9)
- 空 doc / 単色のみ (fillMap に null) / gradient / mixed multi-fill /
image ノード自身 / mesh_gradient kind / stroke.fill gradient /
effects 配列 (enabled フィルタ) / nested frame 再帰
- tests/parser.test.ts 拡張 (+10)
- passthrough fields 保持 (known / unknown 両方)
- group / line / polygon / path の基本パース
- frame 配下の unsupported 子
- null / string 入力の拒否
- error.summary が non-empty
既存 parser tests 9 → 19。
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
231 → 250 tests (+19)。
tests/paintRegistry.test.ts新規buildPaintRegistryの全 paint kind / multi-fill / effect フィルタ / 再帰tests/parser.test.ts拡張schema 直接テストについて
src/pen/schema.tsはparsePen経由で使われるため、parsePenの統合テストでカバーするほうが実用的と判断。直接 zod schema を検証するテストは追加しなかった。また、zod の union に
passthrough: z.object({ type: z.string(), id: z.string() }).passthrough()が入っているため、ルールに違反した有効型（例: rectangle の stroke.align に invalid 値）は unsupported にフォールバックして ok=true で通る。これは意図した挙動（ユーザーの .pen を部分的にでも表示するため）。Test plan
npm testで 19 ファイル / 250 件全 passnpm run buildOK🤖 Generated with Claude Code