ContactForm: Hide subject dropdown when only one contact is available#88
Open
Codencode wants to merge 2 commits intoPrestaShop:devfrom
Open
ContactForm: Hide subject dropdown when only one contact is available#88Codencode wants to merge 2 commits intoPrestaShop:devfrom
Codencode wants to merge 2 commits intoPrestaShop:devfrom
Conversation
|
Hello @Codencode! This is your first pull request on contactform repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Hlavtox
previously approved these changes
Feb 12, 2026
Author
|
@kpodemski Thanks |
tblivet
approved these changes
Feb 17, 2026
tblivet
previously requested changes
Feb 17, 2026
tblivet
left a comment
There was a problem hiding this comment.
Sorry, I didn’t see the question about the CI break!
Any thoughts on this? @kpodemski
kpodemski
approved these changes
Feb 17, 2026
tblivet
approved these changes
Feb 17, 2026
Touxten
approved these changes
Feb 17, 2026
Contributor
Touxten
left a comment
There was a problem hiding this comment.
Ok for CI it's for all native module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of rendering a
<select>with a single option, the module now automatically sets theid_contactvalue using a hidden input.This improves the user experience by removing an unnecessary selection while preserving the expected form behavior.
- Delete the contacts, leaving only one
- In the front office, go to the Contact page
- The
Subject Headinglabel and its related select dropdown should not be displayedNOTE:
If you are using the classic theme, delete (or rename) the file
themes/classic/modules/contactform/views/templates/widget/contactform.tpl.If you are using the
hummingbirdtheme, do the same.This is essential to see the modification.
PrestaShop/classic-theme#201
Before
After
Note
If this PR is approved, I will update the
modules/contactform/views/templates/widget/contactform.tplfile in both the classic and hummingbird themes accordingly.