Skip to content

Conversation

@noahho
Copy link
Collaborator

@noahho noahho commented Jan 9, 2026

Remove unnecessary comment about process_idx parameter.

Issue

Please link the corresponding GitHub issue. If an issue does not already exist,
please open one to describe the bug or feature request before creating a pull request.

This allows us to discuss the proposal and helps avoid unnecessary work.

Motivation and Context


Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?


Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • A changelog entry has been added (see changelog/README.md), or "no changelog needed" label requested.
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

Remove unnecessary comment about process_idx parameter.
@noahho noahho requested a review from a team as a code owner January 9, 2026 16:36
@noahho noahho requested review from bejaeger and Copilot and removed request for a team January 9, 2026 16:36
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@noahho noahho merged commit 0b3de8e into main Jan 9, 2026
4 of 5 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a comment from the _fit_preprocessing_one function's docstring that referred to a non-existent process_idx parameter. This is a good cleanup that improves the accuracy of the documentation. I see no issues with this change.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an outdated docstring comment that documented a non-existent process_idx parameter in the _fit_preprocessing_one function. The parameter does not exist in the function signature and is not used anywhere in the function body.

  • Cleanup of incorrect documentation in _fit_preprocessing_one function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants