Skip to content

Conversation

@noahho
Copy link
Collaborator

@noahho noahho commented Jan 9, 2026

Issue

Please link the corresponding GitHub issue. If an issue does not already exist,
please open one to describe the bug or feature request before creating a pull request.

This allows us to discuss the proposal and helps avoid unnecessary work.

Motivation and Context


Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?


Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • A changelog entry has been added (see changelog/README.md), or "no changelog needed" label requested.
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

Copilot AI review requested due to automatic review settings January 9, 2026 16:41
@noahho noahho requested a review from a team as a code owner January 9, 2026 16:41
@noahho noahho requested review from klemens-floege and removed request for a team January 9, 2026 16:41
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors imports to be more specific, changing from tabpfn.preprocessing to tabpfn.preprocessing.steps. The change is correct and improves code organization. I've added one suggestion to use the inspect module for class discovery, which is a more standard and readable approach for introspection.

@noahho noahho added the no changelog needed PR does not require a changelog entry label Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the import statement in the test file to correctly reference the steps module within tabpfn.preprocessing, ensuring that the _get_preprocessing_steps() helper function can properly iterate over the preprocessing step classes.

Key Changes:

  • Updated import from from tabpfn import preprocessing to from tabpfn.preprocessing import steps
  • Changed iteration target from preprocessing.__dict__.values() to steps.__dict__.values() to correctly access step classes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@noahho noahho disabled auto-merge January 11, 2026 08:40
@noahho noahho merged commit 0777167 into main Jan 11, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog needed PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants