Merged
Conversation
TheKodeToad
reviewed
Oct 3, 2025
src/main/java/io/github/zekerzhayard/forgewrapper/installer/detector/IFileDetector.java
Outdated
Show resolved
Hide resolved
TheKodeToad
reviewed
Oct 3, 2025
src/main/java/io/github/zekerzhayard/forgewrapper/installer/detector/IFileDetector.java
Outdated
Show resolved
Hide resolved
1 task
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
TheKodeToad
approved these changes
Oct 3, 2025
Member
TheKodeToad
left a comment
TheKodeToad
left a comment
There was a problem hiding this comment.
Really tempted to point out the error message duplication >:(
but that's a nitpick
This was referenced Oct 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix PrismLauncher/issues/4190
It removes the hard dependency on
cpw.mods.modlauncher.LauncherAnd tries to dynamically load multiple classes that are know:
cpw.mods.modlauncher.Launcherfor forge and old neoforge versionsnet.neoforged.fml.loading.FMLLoaderfor newer neoforge versionsThe reason why I got multiple library checks is that there is no guarantee for forge and neoforge to share the same libraries.
The library choice was made by taking into consideration neoforge maintainers' input:https://discord.com/channels/313125603924639766/922237746460893234/1423759561596342454
The
cpw.mods.modlauncher.ClassTransformerused in #8 will be moved at some point soon.This change was not endorsed by the neoforge team as the correct implementation of this would be to just pass the libraries folder to the forgewrapper from the launcher. But that would require a new launcher release.