Merged
Conversation
Ensures that discovery endpoints actually return the real node ID instead of shadowing the underlying ID of the robot account.
Ensures that node IDs are used for specifying message receivers and maps them internally to a robot ID. Mapping this information is crucial since the robot ID is used for the underlying communication via a socket and is not known to the client. The node ID however, is well known to the client as it can get fetched using discovery endpoints.
DiCanio
force-pushed
the
bug/revise-node-id-handling
branch
from
5bd087b to
b580115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #251.
Opposed to what has been stated in the linked issue, only the
NodeIDis exposed to the client. Everything else is internal information and must not leak. Thus, the change simply exposes the correct information without altering the API (since it was already labelednodeId). When sending message requests thisnodeIdinformation is going to be mapped to the correspondingrobotIdwhich is used for internal communications.This fix does not require any changes to how the application needs to be set up.