Merged
Conversation
Adds options for configuring forward proxy functionality using HTTP (SOCKS is not supported by these changes). Allows for setting the following options: - hostname - port - username - password (via file reference) - whitelist It comes with support for hostname whitelisting, effectively bypassing the proxy if the requested host matches a pattern (given as a Java RegEx). These changes contain 2 different proxy configuration paths which are necessary since the HTTP client used throughout the application is different from the one used exclusively for socket.io connections. The configuration paths provide the same functionality but have to deal with different types of clients that are configured in different ways.
Due to how the application gets configured using its `application.yml` file, proxy related settings will never be null, even if the corresponding env vars are not set. Hence, checks need to take this into account and check for blank strings instead. Without this change authentication would always be configured (just a single example).
Ensures that configured HTTP client references are returned from their corresponding configuration functions. Otherwise, they would simply configure a reference in-place which is only valid within the scope of the configuration function itself. Without this change, SSL and proxy configurations are not working.
Adds a single NGINX instance to the dev setup for development purposes. The instance is configured so that incoming requests are simply forwarded to their corresponding destinations. Additionally, the X-Forwarded-For header is set so that the full IP chain is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for adjusting proxy behavior of the web clients used throughout the application. This can be done by using environment variables (referenced in the README).
The implementation makes use of 2 different proxy configurations due to different web clients being in use. That's because there's a dedicated web client used solely in combination with the
socket.iolibrary. Another client is used for the rest of the application. In the end the functionality is the same but the setup process is different.These changes also allow for specifying non-proxy hosts in order to bypass any proxy in place.
Resolves #244