Conversation
Update README.md
Update README.md
Update README.md
댓글을 수집하는 코드를 추가하였으며, CSV 파일은 수집한 댓글에서 생성된 데이터입니다. 수집된 데이터를 바탕으로 분석 및 기능 개발을 지원하기 위해 추가했습니다.
- remove PR template header - lint agents/music/modules/models.py with ruff
qjrm1430
requested changes
Jun 24, 2025
Member
qjrm1430
left a comment
qjrm1430
left a comment
There was a problem hiding this comment.
comments.py는 Langgraph workflow 형태로 변경해주세요. management 폴더의 state.py와 node.py, workflow.py에서 구현해주시고 만약 selenium이 langgraph에서 동작하지 않는다면 이슈로 남겨주시고 해당 파일은 tests 폴더에 보관해주세요.
csv 파일 같은 경우엔 노션 데이터베이스에 올려주시고 형빈님과 준성님을 코멘트해주세요!
[hotfix] Github Action에 ruff 추가
workflow.py, node.py, state.py 파일에 comment 수집 코드를 추가했습니다. uv sync 시마다 제거되던 langchain-openai 0.3.27 버전을 project.toml에 명시하였고, 누락된 패키지로 인해 발생하는 문제를 해결하기 위해 langchain-core 0.3.67 버전을 uv.lock에 추가했습니다. langgraph.json에서는 관리용 workflow만 남겨 원활한 실행 환경을 구성했습니다. 또한, basenode.py의 initdrivernode에서 발생하는 오류를 해결하기 위해 *args를 추가했습니다.
…pany" to "Act 1: Entertainment" and adjust related environment variables and documentation accordingly.
docs, chore: Update project references from "Pseudo Entertainment Company" to "Act 1: Entertainment" and adjust related environment variables and documentation accordingly.
코드 내 네이밍을 기존 포맷 가이드에 맞게 수정함. 일관된 코드 스타일을 유지하고 가독성을 높이기 위함.
Collaborator
Author
|
커밋했습니다. 확인 부탁드립니다! |
qjrm1430
reviewed
Jul 27, 2025
| @@ -1,8 +1,9 @@ | |||
| from langgraph.graph import StateGraph | |||
| from langgraph.graph import StateGraph, END | |||
Member
There was a problem hiding this comment.
- END를 따로 작성하지 않아도 __end__로 넣어도 됩니다.
- management 폴더명을 comment_collection으로 변경해주세요.
| "langgraph>=0.3.27", | ||
| "langchain-community>=0.2.17", | ||
| "python-dotenv>=1.0.1", | ||
| "langchain-openai>=0.3.27", |
Member
There was a problem hiding this comment.
- 루트 패키지가 아닌 소속된 agent 패키지에 종속성으로 추가해주세요.
- Act-Contribution Guidebook 19page를 참고해주세요.
| "music": "./agents/music/workflow.py:music_workflow", | ||
| "image": "./agents/image/workflow.py:image_workflow", | ||
| "management": "./agents/management/workflow.py:management_workflow" | ||
| "management": "./agents/management/workflow.py:management_workflow", |
Member
There was a problem hiding this comment.
- PR로 올리시는 최종 langgraph.json 파일에는 테스트 시 삭제했던 기존 Agent들을 다시 추가해놓아주세요.
| workflow.add_edge("extract_comments", "save_comments") | ||
|
|
||
| # 조건부 엣지 | ||
| def has_more_posts(state: CommentWorkflowState) -> str: |
| from agents.management.modules.state import CommentWorkflowState | ||
|
|
||
|
|
||
| class ManagementWorkflow(BaseWorkflow): |
|
|
||
|
|
||
|
|
||
| class CommentsWorkflow(BaseWorkflow): |
Member
There was a problem hiding this comment.
- CommentCollectionWorkflow으로 변경해주세요.
| "music": "./agents/music/workflow.py:music_workflow", | ||
| "image": "./agents/image/workflow.py:image_workflow", | ||
| "management": "./agents/management/workflow.py:management_workflow" | ||
| "comments": "./agents/collect_comments/workflow.py:collect_comments_workflow" |
Member
There was a problem hiding this comment.
"main": "./agents/workflow.py:main_workflow",
"text": "./agents/text/workflow.py:text_workflow",
"music": "./agents/music/workflow.py:music_workflow",
"image": "./agents/image/workflow.py:image_workflow",
추가해주세요.
|
|
||
| # 조건부 엣지 | ||
| def has_more_posts(state: CollectCommentsState) -> str: | ||
| return "load_comments" if state.current_post_url else "__end__" |
Member
There was a problem hiding this comment.
conditions.py 파일에다 해당 함수를 넣어서 해당 workflow.py에서 import로 불러온 후 사용해주세요.
| # 엣지 설정 | ||
| workflow.set_entry_point("init_driver") | ||
| workflow.add_edge("init_driver", "collect_post_links") | ||
| workflow.set_entry_point("collect_post_links") |
Member
There was a problem hiding this comment.
start -> collect_post_links add_edge로 연결해주세요.
|
|
||
|
|
||
|
|
||
| class InitDriverNode(BaseNode): |
Member
There was a problem hiding this comment.
def init(self, *args, **kwargs):
super().init(*args, **kwargs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: 새로운 기능 추가.
title: "feat: 댓글 수집 코드 및 데이터 추가"
labels: ''
assignees: ''
📝 Summary
댓글을 수집하는 코드를 추가하였으며,
CSV 파일은 수집한 댓글에서 생성된 데이터입니다.
수집된 데이터를 바탕으로 분석 및 기능 개발을 지원하기 위해 추가했습니다.
✅ Checklist
[ ] 관련 이슈가 명시되어 있습니다.[ ] 문서 업데이트가 포함되었습니다.📄 Description
💡 Notice (Optional)
🔗 Related Issue(s)