Open
Conversation
LJBang
reviewed
Sep 10, 2025
Collaborator
LJBang
left a comment
LJBang
left a comment
There was a problem hiding this comment.
너무 늦게 리뷰드리네요 ㅠㅠ
몇 가지 궁금한 것만 체크했는데, 휴가시니 여유롭게 보시면 될 것 같습니다~
|
|
||
| class ResourceManagementNode(BaseNode): | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
혹시 pre-commit lint가 제대로 돌아갔나요? 공백이 넘 많은 것 같아서요..
| class ResourceManagementNode(BaseNode): | ||
|
|
||
|
|
||
| load_dotenv(override=True) |
Collaborator
There was a problem hiding this comment.
이 파일에서 env 사용 안하는 것처럼 보이는데, 여기서 dotenv 불러주어야 하나요? 메인 workflow에서 부르고 있는데 또 부르는 것 같아보여서 여쭤봐요!
| ) | ||
|
|
||
|
|
||
| class InstagramAnalysisReportOutput(BaseModel): |
Collaborator
There was a problem hiding this comment.
뭐 취향 차이겠지만 이런 값 객체들만 따로 파일로 모으는건 어떠신가요?
| return [] | ||
|
|
||
|
|
||
| class InstagramCommentsAnalysisNode(BaseNode): |
Collaborator
There was a problem hiding this comment.
해당 노드 llm 객체 만드는 부분이랑, chain 사용하는 부분에서, models.py와 chains.py로 따로 안 빼고 여기 메서드에 통합하신 이유가 있으실까용
| parsed_output = InstagramCommentsAnalysisOutput.model_validate_json( | ||
| json_content | ||
| ) | ||
| except Exception as parse_error: |
Collaborator
There was a problem hiding this comment.
웬만하면 다른 에러는 안 날 것 같긴 한데, 이러면 모든 에러가 parse_error처럼 걸려서 디버깅에 방해될 수도 있으니 차라리 ParseException 같은 에러 하나 만들어서 그거 잡는 것도 좋을 것 같슴다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
✅ Checklist
📄 Description
instagram comment를 분석하는 에이전트 최종 PR입니다.
💡 Notice (Optional)
🔗 Related Issue(s)