(POC)Improve Users and Groups - Permission Performance #8473
Conversation
rodriquelca
changed the title
caleeli
changed the title
|
rodriquelca
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| $this->loadUserPermissions(), | ||
| $this->loadGroupPermissions() | ||
| ); | ||
| // return array_merge( |
There was a problem hiding this comment.
Can we remove this comments please?
| public function hasPermission($permissionString) | ||
| { | ||
| $permissionStrings = $this->loadPermissions(); | ||
| // $permissionStrings = $this->loadPermissions(); |
There was a problem hiding this comment.
Can we remove the comments please?
| /** | ||
| * Check if user has any of the given permissions | ||
| */ | ||
| // public function hasAnyPermission(array $permissions): bool |
There was a problem hiding this comment.
Can we remove the commented methods please?
| */ | ||
| private function addCategoryViewPermissions(array $permissions): array | ||
| { | ||
| $addFor = [ |
There was a problem hiding this comment.
Should this be applied to other assets that have categories, like decision tables, data connectors, flow genies, etc?
| */ | ||
| public function boot(): void | ||
| { | ||
| // Publish configuration if needed |
There was a problem hiding this comment.
Can we remove the comment code please?
| $this->loadUserPermissions(), | ||
| $this->loadGroupPermissions() | ||
| ); | ||
| // return array_merge( |
There was a problem hiding this comment.
commented code, delete it.
tests/Feature/ProfileTest.php
Outdated
| $user->is_administrator = true; | ||
| $user->save(); | ||
| $user->refresh(); | ||
| $user->invalidatePermissionCache(); // ✅ Invalidar cache para que los permisos tomen efecto |
There was a problem hiding this comment.
change it to English.
| /** | ||
| * Check if user has any of the given permissions | ||
| */ | ||
| // public function hasAnyPermission(array $permissions): bool |
There was a problem hiding this comment.
review the commented code.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
refactor Permission module
Solution
How to Test
Describe how to test that this solution works.
Related Tickets & Packages
Code Review Checklist