Skip to content

FOUR-26751: Make the dangerous_extensions verification configurable #8537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nolanpro merged 1 commit into from
Oct 2, 2025
Merged

FOUR-26751: Make the dangerous_extensions verification configurable #8537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ProcessMaker/Http/Controllers/Api/ProcessRequestFileController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,15 +450,17 @@ public function destroy(Request $laravel_request, ProcessRequest $request, $file
private function validateFile(UploadedFile $file, &$errors)
{
// Explicitly reject archive files for security
$this->rejectArchiveFiles($file, $errors);
if (config('files.enable_dangerous_validation')) {
$this->rejectArchiveFiles($file, $errors);
}

// Validate file extension if enabled
if (config('files.enable_extension_validation', true)) {
if (config('files.enable_extension_validation')) {
$this->validateFileExtension($file, $errors);
}

// Validate MIME type vs extension if enabled
if (config('files.enable_mime_validation', true)) {
if (config('files.enable_mime_validation')) {
$this->validateExtensionMimeTypeMatch($file, $errors);
}

Expand Down
10 changes: 10 additions & 0 deletions config/files.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@
'mp4' => ['video/mp4'],
],

/*
|--------------------------------------------------------------------------
| Enable DANGEROUS Validation
|--------------------------------------------------------------------------
|
| Whether to enable dangerous file validation that checks against
|
*/
'enable_dangerous_validation' => env('ENABLE_DANGEROUS_VALIDATION', true),

/*
|--------------------------------------------------------------------------
| Enable MIME Type Validation
Expand Down
Loading