Skip to content

chore: bump version to 1.4.0 (TOU-39)#28

Merged
ProduktEntdecker merged 1 commit intomainfrom
feature/tou-39-version-bump
Jan 1, 2026
Merged

chore: bump version to 1.4.0 (TOU-39)#28
ProduktEntdecker merged 1 commit intomainfrom
feature/tou-39-version-bump

Conversation

@ProduktEntdecker
Copy link
Copy Markdown
Owner

@ProduktEntdecker ProduktEntdecker commented Jan 1, 2026

Summary by CodeRabbit

  • Chores
    • Version bumped to 1.4.0 across application configuration and build scripts.

✏️ Tip: You can customize this high-level summary in your review settings.

Update version numbers in:
- Info.plist
- build-app.sh
- create-dmg.sh

Changelog (v1.4.0):

Added:
- Real-time progress UI showing each process being restarted
- Per-process success/failure indicators
- Admin privilege request when TouchBarServer can't be restarted
- "Restart Computer" option as fallback

Fixed:
- False "Success" message when TouchBarServer wasn't actually restarted
- Silent failures for root-owned processes

Changed:
- Redesigned restart flow with Nielsen Heuristics principles
- Improved error messaging with actionable guidance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 1, 2026

📝 Walkthrough

Walkthrough

The pull request updates the application version from 1.3.0 to 1.4.0 across three configuration and build script files: the app's Info.plist, the build script, and the DMG creation script. No functional logic or behavioral changes are introduced.

Changes

Cohort / File(s) Summary
Version bump across configuration and build files
App/Resources/Info.plist, App/build-app.sh, App/create-dmg.sh
Updated version string from 1.3.0 to 1.4.0 in CFBundleShortVersionString, VERSION variable, and DMG/README references. No logic or control flow modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • touchbarfix#20: Performs identical version-bump changes to the same files (App/Resources/Info.plist, App/build-app.sh, App/create-dmg.sh).

Poem

🐰 A version hops from one-point-three,
To one-point-four, as versions should be,
Through plist and scripts, the numbers align,
A bump in the build, everything's fine!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: updating the app version from 1.3.0 to 1.4.0 across multiple configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@ProduktEntdecker ProduktEntdecker merged commit 4d60b03 into main Jan 1, 2026
1 of 2 checks passed
@ProduktEntdecker ProduktEntdecker deleted the feature/tou-39-version-bump branch January 1, 2026 01:14
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
App/build-app.sh (1)

13-13: VERSION variable appears unused.

The version bump to 1.4.0 is correct. However, the VERSION variable is not referenced anywhere in the script. Consider either:

  1. Using it to dynamically update the Info.plist version (via sed or PlistBuddy)
  2. Using it to verify version consistency between the script and Info.plist
  3. Removing it if it's not needed

This would help ensure version consistency across files and reduce manual update steps.

💡 Example: Using VERSION to verify Info.plist consistency

After line 76 where Info.plist is copied, you could add:

# Verify version consistency
PLIST_VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" "$APP_BUNDLE/Contents/Info.plist")
if [ "$PLIST_VERSION" != "$VERSION" ]; then
    echo -e "${YELLOW}⚠️ Warning: Version mismatch! Script: $VERSION, Info.plist: $PLIST_VERSION${NC}"
fi
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 311b2ba and c8bb1eb.

📒 Files selected for processing (3)
  • App/Resources/Info.plist
  • App/build-app.sh
  • App/create-dmg.sh
🧰 Additional context used
🪛 Shellcheck (0.11.0)
App/build-app.sh

[warning] 13-13: VERSION appears unused. Verify use (or export if used externally).

(SC2034)

🔇 Additional comments (3)
App/create-dmg.sh (1)

7-7: Version bump looks correct.

The DMG_NAME and README version references have been updated consistently to 1.4.0, aligning with the PR objective.

Also applies to: 38-38

App/Resources/Info.plist (2)

22-22: Version string updated correctly.

The CFBundleShortVersionString has been updated to 1.4.0 as expected.


23-24: Consider incrementing CFBundleVersion.

While the version string update is correct, the CFBundleVersion (build number) remains at "5". Apple's guidelines typically recommend incrementing the build number for each release, even for minor updates. Verify whether this should be incremented to "6" or if there's a specific reason to keep it at "5".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant