chore: bump version to 1.4.0 (TOU-39)#28
Conversation
Update version numbers in: - Info.plist - build-app.sh - create-dmg.sh Changelog (v1.4.0): Added: - Real-time progress UI showing each process being restarted - Per-process success/failure indicators - Admin privilege request when TouchBarServer can't be restarted - "Restart Computer" option as fallback Fixed: - False "Success" message when TouchBarServer wasn't actually restarted - Silent failures for root-owned processes Changed: - Redesigned restart flow with Nielsen Heuristics principles - Improved error messaging with actionable guidance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe pull request updates the application version from 1.3.0 to 1.4.0 across three configuration and build script files: the app's Info.plist, the build script, and the DMG creation script. No functional logic or behavioral changes are introduced. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
App/build-app.sh (1)
13-13: VERSION variable appears unused.The version bump to 1.4.0 is correct. However, the VERSION variable is not referenced anywhere in the script. Consider either:
- Using it to dynamically update the Info.plist version (via
sedorPlistBuddy)- Using it to verify version consistency between the script and Info.plist
- Removing it if it's not needed
This would help ensure version consistency across files and reduce manual update steps.
💡 Example: Using VERSION to verify Info.plist consistency
After line 76 where Info.plist is copied, you could add:
# Verify version consistency PLIST_VERSION=$(/usr/libexec/PlistBuddy -c "Print CFBundleShortVersionString" "$APP_BUNDLE/Contents/Info.plist") if [ "$PLIST_VERSION" != "$VERSION" ]; then echo -e "${YELLOW}⚠️ Warning: Version mismatch! Script: $VERSION, Info.plist: $PLIST_VERSION${NC}" fi
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
App/Resources/Info.plistApp/build-app.shApp/create-dmg.sh
🧰 Additional context used
🪛 Shellcheck (0.11.0)
App/build-app.sh
[warning] 13-13: VERSION appears unused. Verify use (or export if used externally).
(SC2034)
🔇 Additional comments (3)
App/create-dmg.sh (1)
7-7: Version bump looks correct.The DMG_NAME and README version references have been updated consistently to 1.4.0, aligning with the PR objective.
Also applies to: 38-38
App/Resources/Info.plist (2)
22-22: Version string updated correctly.The CFBundleShortVersionString has been updated to 1.4.0 as expected.
23-24: Consider incrementing CFBundleVersion.While the version string update is correct, the CFBundleVersion (build number) remains at "5". Apple's guidelines typically recommend incrementing the build number for each release, even for minor updates. Verify whether this should be incremented to "6" or if there's a specific reason to keep it at "5".
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.