Skip to content

Conversation

@HikariCalyx
Copy link

No description provided.

@HikariCalyx HikariCalyx requested a review from Prof9 April 23, 2023 14:37
@HikariCalyx HikariCalyx changed the title Add EXE4-6 Chinese support. Add EXE AC Chinese support. Apr 26, 2023
@@ -12,6 +12,20 @@ cdbs = mmbn1s,mmbn1-lc
tblf = exeac-exe1-utf8
vals = mmbn-jump,mmbn-code,mmbn1-mugshots

[Game]
name = exe1-ac-chs
full = Rockman EXE (Advance Collection)(Chinese Simplified, May not accurate)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the ", May not accurate" part (also for EXE1 CHT, EXE2 and EXE3)

6440=×
6441==
6442=:
6443=[!!]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: ‼️

Comment on lines 83 to 84
6452=(
6453=)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use [(] and [)]. The () which are used predominantly in the script should have =( and =), the other ones should have =[(] and =[)]

6451=%
6452=(
6453=)
6454=[$]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use $ as it is the only instance of this character in the table file.

6441==
6442=:
6443=[!!]
6444=?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: ? (ASCII ?) rather than full-width

Comment on lines +636 to +637
667B=(
667C=)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: [(] and [)] depending on if these are the parentheses primarily used in the script (see notes above)

6688=#
6689=‘
668A==
668B=[Space]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use: [space] for consistency with other table files

6498=圈
6499=國
649A=圖
649B=—
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an em dash, but I guess is already in use... maybe should be [一]?

Comment on lines +2871 to +2872
6F36=[$6F36]
6F37=[$6F37]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be [V] and [S]; these are not used in font_cht_05 but do appear in menu_spr_cht_05.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I made some errors when I created the exeac-exe5-chs-utf8.tbl, could you include these?

67CD=哲
6826=堕
6A82=济
6C63=蜕
6D10=辻
6DC9=髓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants