-
Notifications
You must be signed in to change notification settings - Fork 4
Add EXE AC Chinese support. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TextPet/plugins/games.ini
Outdated
| @@ -12,6 +12,20 @@ cdbs = mmbn1s,mmbn1-lc | |||
| tblf = exeac-exe1-utf8 | |||
| vals = mmbn-jump,mmbn-code,mmbn1-mugshots | |||
|
|
|||
| [Game] | |||
| name = exe1-ac-chs | |||
| full = Rockman EXE (Advance Collection)(Chinese Simplified, May not accurate) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the ", May not accurate" part (also for EXE1 CHT, EXE2 and EXE3)
| 6440=× | ||
| 6441== | ||
| 6442=: | ||
| 6443=[!!] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use: ‼️
| 6452=( | ||
| 6453=) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use [(] and [)]. The () which are used predominantly in the script should have =( and =), the other ones should have =[(] and =[)]
| 6451=% | ||
| 6452=( | ||
| 6453=) | ||
| 6454=[$] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use $ as it is the only instance of this character in the table file.
| 6441== | ||
| 6442=: | ||
| 6443=[!!] | ||
| 6444=? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use: ? (ASCII ?) rather than full-width ?
| 667B=( | ||
| 667C=) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use: [(] and [)] depending on if these are the parentheses primarily used in the script (see notes above)
| 6688=# | ||
| 6689=‘ | ||
| 668A== | ||
| 668B=[Space] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use: [space] for consistency with other table files
| 6498=圈 | ||
| 6499=國 | ||
| 649A=圖 | ||
| 649B=— |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is an em dash, but I guess 一 is already in use... maybe should be [一]?
| 6F36=[$6F36] | ||
| 6F37=[$6F37] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be [V] and [S]; these are not used in font_cht_05 but do appear in menu_spr_cht_05.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I made some errors when I created the exeac-exe5-chs-utf8.tbl, could you include these?
67CD=哲
6826=堕
6A82=济
6C63=蜕
6D10=辻
6DC9=髓
No description provided.