fix: Include User-Agent header in OUI data download#3
Open
Cyberistic wants to merge 1 commit intoProfessionallyEvil:mainfrom
Open
fix: Include User-Agent header in OUI data download#3Cyberistic wants to merge 1 commit intoProfessionallyEvil:mainfrom
Cyberistic wants to merge 1 commit intoProfessionallyEvil:mainfrom
Conversation
Added User-Agent header to the request for OUI data.
There was a problem hiding this comment.
Pull request overview
Updates the IEEE OUI download request in nmap_oui_update.py to include a User-Agent header, addressing IEEE rejecting automated downloads (HTTP 418) and unblocking nmap_oui_update runs.
Changes:
- Add a
User-Agentheader to the IEEE OUIrequests.get(...)call. - Keep existing download validation logic based on HTTP 200 and content check.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+100
to
+101
| headers = {"User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36"} | ||
| res = requests.get(IEEE_URL, headers=headers) |
| dst = os.path.join(get_root_program_path(), OUI_DATA) | ||
| res = requests.get(IEEE_URL) | ||
| headers = {"User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36"} | ||
| res = requests.get(IEEE_URL, headers=headers) |
Comment on lines
+100
to
+101
| headers = {"User-Agent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36"} | ||
| res = requests.get(IEEE_URL, headers=headers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added User-Agent header to the request for OUI data.
fixes #2