Allow up to three consecutive exceptions before cutting the feeds of face or eye tracking#212
Open
Sebane1 wants to merge 2 commits intoProject-Babble:mainfrom
Conversation
…eye or face tracking.
|
|
Collaborator
|
Thanks for your PR! I see you have tested this against IP cameras, have you also tested this against web-cameras, etc.? |
Author
I've primarily tested against MJPEG feeds distributed over IP. I don't think I have access to other camera types beyond that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A solution I ended up throwing together to bypass the problem noted in this issue
#210
Simply opting to not cut the feed after an exception appears to allow the feed to continue without consequence. But I've capped it to ignore only the first three exceptions in a row before stopping.