Open
Conversation
SummerSigh
force-pushed
the
module-division-fix
branch
from
6dda4fd to
a88c5b9
Compare
TwoKeyDictionary.Add rejected entries with duplicate Key2 values, so only the first sub-shape per OSC address was registered (e.g. LipPuckerLowerLeft but not UpperLeft/UpperRight/LowerRight). Remove the ContainsKey2 guard so all sub-shapes are registered, and remove the compensating *4/*2 multipliers that are no longer needed now that every sub-shape receives the true value.
SummerSigh
force-pushed
the
module-division-fix
branch
from
a88c5b9 to
f9879b0
Compare
Contributor
|
Tested and works fine on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The baballonia module had a single incorrect Boolean expression in line 33 that cascaded to a bunch of bandaid fixes being applied to make other shapes work within the module. when using systems with more advanced tracking (like Basis), it was clear that only the LowerLeft of that shape was being driven. Now that's been fixed so all split shapes drive at their proper values without the need for the hacky multiplication fixes we had in the past.