Skip to content

[FIX]rollback vdev config for container#13

Merged
archlitchi merged 1 commit intoProject-HAMi:masterfrom
joy717:master
Mar 20, 2025
Merged

[FIX]rollback vdev config for container#13
archlitchi merged 1 commit intoProject-HAMi:masterfrom
joy717:master

Conversation

@joy717
Copy link
Copy Markdown
Contributor

@joy717 joy717 commented Mar 20, 2025

this commit ca474a8#diff-5f1987bb4cb78beeb0a3a8e29dce4e473add246f860dd74eb83a28b8414dbbf8R381

change the vdev.conf device_id from 0 to host dcu deviceID.
don't know why here is hard code to 0.

but we found that when a node contains 1+ dcu, it will mount total dcu to container instead of a vdev when container bind to the 2nd device.

anyway, rollback to hard coded 0 for device_id could work

@hami-robott
Copy link
Copy Markdown

hami-robott bot commented Mar 20, 2025

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • ae3b77e rollback vdev config for container
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hami-robott hami-robott bot added the size/XS label Mar 20, 2025
@hami-robott
Copy link
Copy Markdown

hami-robott bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joy717

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: jiayu.chen <jiayu.chen@zstack.io>
@archlitchi
Copy link
Copy Markdown
Member

/lgtm

@archlitchi archlitchi merged commit 12bb96d into Project-HAMi:master Mar 20, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants