fix(create vdevfile with new format device uuid):#18
Open
peachest wants to merge 1 commit intoProject-HAMi:masterfrom
Open
fix(create vdevfile with new format device uuid):#18peachest wants to merge 1 commit intoProject-HAMi:masterfrom
peachest wants to merge 1 commit intoProject-HAMi:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: peachest The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
get device index from new format device uuid to create vdev file Signed-off-by: houyuxi <yuxi.hou@transwarp.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR #17, the serial numbers of physical devices were used to build the new version of the UUID, but a change to the Plugin's
createvdevFilesfunction was missed.This PR Fixed the function
createvdevFilesstill use functiongetIndexFromUUIDto extracts the physical device index from the old version of the UUID, migrated the implementation to extract the serial number from the new version of the UUID and further obtain the device serial number.