Skip to content

Ai 230 #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Oct 20, 2023
Merged

Ai 230 #894

merged 26 commits into from
Oct 20, 2023

Conversation

@lillie-dae
Copy link
Collaborator

@lillie-dae lillie-dae commented Oct 17, 2023 •
edited
Loading

Description

AI-230 Creation of an ArtifactsReceivedEvent
AI-231 Addition of type to the Output Artifacts object and validation

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

lillie-dae and others added 20 commits October 13, 2023 11:11
@lillie-dae
changes to add output artifact and validation
7786e8f 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor change to using statements
b97b6d5 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
remove comment
b7d06ad 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
Merge branch 'develop' into AI-229-add-output-artifact-and-validation
7c26b74
@lillie-dae
add header files
1584e56 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
Merge branch 'AI-229-add-output-artifact-and-validation' of https://g…
6351295 
…ithub.com/Project-MONAI/monai-deploy-workflow-manager into AI-229-add-output-artifact-and-validation
@lillie-dae
import missing references
7a2e104 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
updated packages
ca2fa88 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
bump package
84d7db0 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
bump package to release version
ab793e1 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@neildsouth
adding lisener for artifact received
d5d1abc 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@lillie-dae
updated ProcessArtifactReceived
ffe1282 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@neildsouth
small fixups
7c9554f 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@lillie-dae
added artifact repo
f7dfdaf 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
Merge branch 'AI-230' of https://github.com/Project-MONAI/monai-deplo…
541eeef 
…y-workflow-manager into AI-230
@neildsouth
fix up tests
8f8781d 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
fix tests
9c35e22 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@lillie-dae
merge in dev
4206b93 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
added EventPayloadValidatorTests and WorkflowExecuterServiceTests and…
9b5a5a9 
… minor fixes

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
reduced code duplication
d0b61b2 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
neildsouth
neildsouth reviewed Oct 17, 2023
View reviewed changes
@neildsouth
adding indexs
4d32c70 
Signed-off-by: Neil South <neil.south@answerdigital.com>
lillie-dae and others added 5 commits October 19, 2023 11:32
@lillie-dae
minor fixes
a9898e4 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor fixes
69d7137 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor fixes
ee61cf9 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@neildsouth
final adjustments
5388837 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth
merge in
df25fa2 
Signed-off-by: Neil South <neil.south@answerdigital.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

79.1% 79.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@neildsouth neildsouth merged commit 8b97086 into develop Oct 20, 2023
@neildsouth neildsouth deleted the AI-230 branch October 20, 2023 14:00
@mocsharp mocsharp modified the milestones: 1.30, 0.1.30, 0.2.0 Jun 6, 2024
@mocsharp mocsharp added the enhancement New feature or request label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neildsouth neildsouth neildsouth left review comments

@DanielNuttall-AD DanielNuttall-AD DanielNuttall-AD approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lillie-dae @DanielNuttall-AD @neildsouth @mocsharp