Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a systematic refactoring to replace entity type selectors using type=#lib:living,type=!player with the more concise tag #lib:living_without_player throughout the codebase.
Changes:
- Entity selector syntax standardization across object, mob, effect, and artifact files
- Improved code readability and maintainability through consistent selector patterns
Reviewed changes
Copilot reviewed 300 out of 347 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Multiple object files (1100, 1099, 1098, etc.) | Updated entity selectors in hit detection and damage functions |
| Multiple artifact files (0001-1282) | Standardized entity selectors in trigger and damage logic |
| Multiple effect files (0243, 0316, 0320, 0330, 0603) | Updated entity selectors in tick and damage functions |
| Multiple mob files (0019, 0084, 0219, 0234, 0274, 0444) | Replaced entity selectors in tick and attack logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.