Skip to content

Comments

💥 呪われた神器の中身をitem_displayに変更#2134

Draft
Lapis-LJA wants to merge 3 commits intomasterfrom
fix/lapis_cursed_artifact
Draft

💥 呪われた神器の中身をitem_displayに変更#2134
Lapis-LJA wants to merge 3 commits intomasterfrom
fix/lapis_cursed_artifact

Conversation

@Lapis-LJA
Copy link
Contributor

Fix #2132

@haiiro2gou haiiro2gou added the ⛏️ minor このPRはパッチアップデートに含められないよ label Jul 30, 2025
Copy link
Member

@haiiro2gou haiiro2gou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0.3 に支障が出そうなのでマージはしない

@haiiro2gou haiiro2gou requested a review from Copilot July 30, 2025 00:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the entity type used for cursed artifacts from armor_stand to item_display to fix issue #2132. The change affects how cursed artifacts are rendered and managed in the game.

  • Replaces armor_stand entities with item_display entities for cursed artifacts
  • Updates entity summoning logic to use macro-based rotation for proper orientation
  • Removes armor stand specific positioning code and replaces with item display configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
core/functions/tick/.mcfunction Updates entity selector to target item_display instead of armor_stand
asset_manager/functions/island/register/construct/summon.m.mcfunction New macro function for summoning item_display entities with proper rotation
asset_manager/functions/island/register/construct/set_data.mcfunction Removes armor stand specific pose/rotation code
asset_manager/functions/island/register/construct/.mcfunction Updates summoning logic to use new macro and changes entity selector

@ChenCMD ChenCMD marked this pull request as draft August 1, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⛏️ minor このPRはパッチアップデートに含められないよ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

呪われた神器の中身をアマスタからitem_displayに変更する

2 participants