Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR changes the entity type used for cursed artifacts from armor_stand to item_display to fix issue #2132. The change affects how cursed artifacts are rendered and managed in the game.
- Replaces
armor_standentities withitem_displayentities for cursed artifacts - Updates entity summoning logic to use macro-based rotation for proper orientation
- Removes armor stand specific positioning code and replaces with item display configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
core/functions/tick/.mcfunction |
Updates entity selector to target item_display instead of armor_stand |
asset_manager/functions/island/register/construct/summon.m.mcfunction |
New macro function for summoning item_display entities with proper rotation |
asset_manager/functions/island/register/construct/set_data.mcfunction |
Removes armor stand specific pose/rotation code |
asset_manager/functions/island/register/construct/.mcfunction |
Updates summoning logic to use new macro and changes entity selector |
TheSkyBlessing/data/asset_manager/functions/island/register/construct/summon.m.mcfunction
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2132