Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a forked version of the PlayerMotion library adapted for Minecraft 1.20.4, including the complete datapack implementation and updating project documentation to reflect the new dependency.
- Integrates the PlayerMotion library as a new directory with full datapack structure
- Updates README.md to document the new library and its licensing
- Replaces test code to demonstrate PlayerMotion API usage
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| PlayerMotion/ | Complete PlayerMotion datapack with API functions, internal math operations, and launch mechanics |
| README.md | Added PlayerMotion library attribution and licensing information |
| TheSkyBlessing/data/minecraft/functions/test2.mcfunction | Updated test function to use PlayerMotion API instead of array operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
PlayerMotion/data/player_motion/functions/internal/math/full_power/tp.mcfunction
Show resolved
Hide resolved
PlayerMotion/data/player_motion/functions/internal/math/eyelevel.mcfunction
Show resolved
Hide resolved
PlayerMotion/data/player_motion/functions/internal/summon/crystal.mcfunction
Outdated
Show resolved
Hide resolved
77d5f6c to
c2cca8e
Compare
bd041c3 to
ef29835
Compare
0ec6564 to
a88f739
Compare
a88f739 to
d5aff3e
Compare
Lapis-LJA
reviewed
Nov 18, 2025
TheSkyBlessing/data/lib/functions/player_motion/launch_looking.mcfunction
Outdated
Show resolved
Hide resolved
7d72e63 to
82e7810
Compare
82e7810 to
a14f2d1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 38 out of 39 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
TheSkyBlessing/data/lib/functions/motion/core/looking/non-player.mcfunction:20
data get storage lib: Pos[*] 10reduces the direction vector resolution to 0.1-block increments (sincePoscomponents are in [-1,1]), which can noticeably quantize motion direction at many angles. If this was changed to compensate for$VectorMagnitudenow being scaled by 10000, consider keeping higher precision (e.g., use a larger scale like 1000 and adjust the laterexecute store result ... doublescale accordingly) so non-player launches remain smooth and accurate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PlayerMotion/data/player_motion/functions/internal/technical/tick.mcfunction
Show resolved
Hide resolved
PlayerMotion/data/player_motion/functions/internal/technical/load.mcfunction
Show resolved
Hide resolved
PlayerMotion/data/player_motion/functions/internal/launch/main.mcfunction
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1516
TODO: KB耐性を計算に入れるか否かの引数を追加しよう