This repository was archived by the owner on Aug 20, 2018. It is now read-only.
Open
Conversation
…eKit dependencies for all extensions to temporarily point at the PromiseKit branch containing the cancellable classes
…t the forked version of PromiseKit
* Delete CancellableGuarantee and all its usages
* In PromiseKit Core: instead of using additional functions and methods with the 'CC' suffix, created a new 'cancellable' function to wrap any Promise or Guarantee
* In the extensions: Rename methods with 'CC' suffix to 'cancellable' prefix (may revisit this)
* Fix the CancellableCatchable 'recover' methods to properly handle cancellation errors
* Added an 'afterTask' property to Guarantee, to keep track of the task for calls to 'after'. This way the timer can be appropriately cancelled if the returned Guarantee is passed to the new 'cancellable' function. (may revisit this)
* Update all cancellable tests for the cancellable API changes
…s to point at the latest version of the PromiseKit 'CoreCancel' branch
* Eliminate duplicate code in the cancellable extensions * When using the 'cancellable' function with the extensions, ensure that the underlying task (if any) is always cancelled * When using the 'cancellable' function, call 'reject' on the underlying promise (wherever possible) if 'cancel' is invoked * Create cancellable wrappers for the extensions only for the cases where there is an underlying task that supports cancellation
* update extensions to point at the latest version of PromiseKit in the pull request * fix "generic parameter 'T' could not be inferred" compilation errors when using the new 'Promise' initializer that takes a cancellable task
… to point at the latest PromiseKit
…s to point at the current PromiseKit
… latest version of PromiseKit
… the latest PromiseKit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the diffs for option 1 of Proposal for PromiseKit cancellation support #896. With option 1 the new cancellation code is included with CorePromise.
There repositories involved with the pull request for option 1 are: