Fix UnicodeDecodeError when serving UI on Windows#7
Open
PhunkyBob wants to merge 1 commit intoPromtEngineer:mainfrom
Open
Fix UnicodeDecodeError when serving UI on Windows#7PhunkyBob wants to merge 1 commit intoPromtEngineer:mainfrom
PhunkyBob wants to merge 1 commit intoPromtEngineer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
Path.read_text()defaults to the system encoding (cp1252). Theui.htmlfile contains characters outside the cp1252 range, causing aUnicodeDecodeErrorat startup when the UI route was first hit.Solution
Explicitly pass
encoding="utf-8"toread_text()in theget_uiendpoint so the file is always decoded correctly regardless of the host system's default encoding.Changed file
src/fs_explorer/server.py—get_uifunction, line 90.How to test
Run
uv run uvicorn fs_explorer.server:app --host 127.0.0.1 --port 8000on a Windows machine and navigate to the UI — no moreUnicodeDecodeError.