Skip to content

Publish the PoseStrategy used to construct MultiPhotonPoseEstimator#4

Merged
kcooney merged 3 commits intomainfrom
kcooney/publish-pose-strategy
Sep 7, 2025
Merged

Publish the PoseStrategy used to construct MultiPhotonPoseEstimator#4
kcooney merged 3 commits intomainfrom
kcooney/publish-pose-strategy

Conversation

@kcooney
Copy link

@kcooney kcooney commented Sep 1, 2025

No description provided.

@spderman3333
Copy link
Collaborator

The following tests are failing:
LimelightPosePublisherTest > publish_withPose
LimelightPosePublisherTest > publish_withoutPose

PhotonVisionPosePublisherTest > publish_withOnePose
PhotonVisionPosePublisherTest > publish_withManyPose

The Limelight tests could probably be removed, but whats more interesting is the Photonvision tests failing.

@kcooney
Copy link
Author

kcooney commented Sep 2, 2025

The following tests are failing

I changed the NetworkTables keys for the cameras to be prefixed by camera/ (to avoid future name conflicts if we add more sub-tables to /Vision/) and didn't notice the tests were failing.

Fixed.

@kcooney kcooney force-pushed the kcooney/publish-pose-strategy branch from 31126d8 to e75ebcd Compare September 2, 2025 00:51
@kcooney
Copy link
Author

kcooney commented Sep 2, 2025

Tests now pass. PTAL @spderman3333

@kcooney kcooney requested a review from spderman3333 September 2, 2025 02:15
@kcooney kcooney removed their assignment Sep 2, 2025
@kcooney kcooney force-pushed the kcooney/publish-pose-strategy branch from e75ebcd to c3c5397 Compare September 2, 2025 04:01
Copy link
Collaborator

@spderman3333 spderman3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kcooney kcooney merged commit 9da69e3 into main Sep 7, 2025
1 check passed
@kcooney kcooney deleted the kcooney/publish-pose-strategy branch September 7, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants