Tickets

app/core/associations/factory_associations.py

@@ -11,22 +11,14 @@
 
 
 class AssociationsFactory(Factory):
-    association_ids = [
-        uuid.uuid4(),
-        uuid.uuid4(),
-        uuid.uuid4(),
-        uuid.uuid4(),
-    ]
+    association_ids = [uuid.uuid4() for _ in range(len(CoreGroupsFactory.groups_ids))]
 
     depends_on = [CoreGroupsFactory]
 
     @classmethod
     async def create_associations(cls, db: AsyncSession):
         descriptions = [
-            "Association 1",
-            "Association 2",
-            "Association 3",
-            "Association 4",
+            f"Association {i + 1}" for i in range(len(CoreGroupsFactory.groups_ids))
         ]
         for i in range(len(CoreGroupsFactory.groups_ids)):
             await cruds_associations.create_association(

app/core/checkout/endpoints_checkout.py

@@ -134,7 +134,7 @@ async def webhook(
         try:
             for module in all_modules:
                 if module.root == checkout.module:
-                    if module.payment_callback is None:
+                    if module.checkout_callback is None:
                         hyperion_error_logger.info(
                             f"Payment: module {checkout.module} does not define a payment callback for checkout (hyperion_checkout_id: {checkout_metadata.hyperion_checkout_id}, HelloAsso checkout_id: {checkout.id})",
                         )
@@ -147,7 +147,7 @@ async def webhook(
                         paid_amount=checkout_payment_model.paid_amount,
                         checkout_id=checkout_payment_model.checkout_id,
                     )
-                    await module.payment_callback(checkout_payment_schema, db)
+                    await module.checkout_callback(checkout_payment_schema, db)
                     hyperion_error_logger.info(
                         f"Payment: call to module {checkout.module} payment callback for checkout (hyperion_checkout_id: {checkout_metadata.hyperion_checkout_id}, HelloAsso checkout_id: {checkout.id}) succeeded",
                     )

app/core/checkout/payment_tool.py

@@ -201,7 +201,7 @@ async def init_checkout(
                         self._helloasso_slug,
                         init_checkout_body,
                     )
-                except UnauthorizedException, BadRequestException:
+                except (UnauthorizedException, BadRequestException):
                     # We know that HelloAsso may refuse some payer infos, like using the firstname "test"
                     # Even when prefilling the payer infos,the user will be able to edit them on the payment page,
                     # so we can safely retry without the payer infos

app/core/feed/utils_feed.py

@@ -78,12 +78,7 @@ async def create_feed_news(
 async def edit_feed_news(
     module: str,
     module_object_id: uuid.UUID,
-    title: str | None,
-    start: datetime | None,
-    end: datetime | None,
-    entity: str | None,
-    location: str | None,
-    action_start: datetime | None,
+    news_edit: schemas_feed.NewsEdit,
     require_feed_admin_approval: bool,
     db: AsyncSession,
     notification_tool: NotificationTool,
@@ -103,14 +98,7 @@ async def edit_feed_news(
     await cruds_feed.edit_news_by_module_object_id(
         module=module,
         module_object_id=module_object_id,
-        news_edit=schemas_feed.NewsEdit(
-            title=title,
-            start=start,
-            end=end,
-            entity=entity,
-            location=location,
-            action_start=action_start,
-        ),
+        news_edit=news_edit,
         db=db,
     )
     if require_feed_admin_approval:
@@ -123,7 +111,7 @@ async def edit_feed_news(
     if require_feed_admin_approval:
         message = Message(
             title="🔔 Feed - a news has been modified",
-            content=f"{entity} has modified {title}",
+            content=f"{news_edit.entity} has modified {news_edit.title}",
             action_module="feed",
         )
         permission = await cruds_permissions.get_permissions_by_permission_name(

app/core/groups/factory_groups.py

@@ -12,23 +12,35 @@
 
 
 class CoreGroupsFactory(Factory):
-    groups_ids = [
-        str(uuid.uuid4()),
-        str(uuid.uuid4()),
-        str(uuid.uuid4()),
-        str(uuid.uuid4()),
-    ]
+    groups_ids = [str(uuid.uuid4()) for _ in range(10)]
 
     depends_on = [CoreUsersFactory]
 
     @classmethod
     async def create_core_groups(cls, db: AsyncSession):
-        groups = ["BDE", "BDS", "Oui", "Pixels"]
+        groups = [
+            "BDE",
+            "BDS",
+            "Pixels",
+            "Commuz",
+            "Musique",
+            "Fablab",
+            "BDA",
+            "Fouquette",
+            "Soli",
+            "SDeC",
+        ]
         descriptions = [
             "Bureau des élèves",
             "Bureau des sports",
-            "Association d'entraide",
             "Association de photographie",
+            "",
+            "",
+            "",
+            "",
+            "",
+            "",
+            "",
         ]
         for i in range(len(groups)):
             await cruds_groups.create_group(

app/core/groups/groups_type.py

@@ -1,7 +1,7 @@
-from enum import Enum
+from enum import StrEnum
 
 
-class GroupType(str, Enum):
+class GroupType(StrEnum):
     """
     In Hyperion, each user may have multiple groups. Belonging to a group gives access to a set of specific permissions.
 
@@ -14,7 +14,7 @@ class GroupType(str, Enum):
     admin = "0a25cb76-4b63-4fd3-b939-da6d9feabf28"
 
 
-class AccountType(str, Enum):
+class AccountType(StrEnum):
     """
     Various account types that can be created in Hyperion.
     Each account type is associated with a set of permissions.