-
Notifications
You must be signed in to change notification settings - Fork 14
Docker support #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Docker support #22
Conversation
|
I added a docker-compose file too, since it is slightly easier to run with. Though, those using docker are probably already familiar with the ins and outs, but at least it shows a bit more explicit what nobs there are to tweak |
|
Excellent PR! Very clean and understandable code and docker files. 5/5 - would docker again! ;-) I think the demo setup could be improved, though. A casual user might not be able to figure out the required steps to make it running. So maybe either put something like in the README, or add the appropriate example files to the repository. Or hint the user towards one of the examples given in To be totally fair, the lack of a good example is not the fault of this PR but rather the state of the current master branch. But it could be an opportunity to improve it. :) |
|
Also, when the example files don't exists upon running docker-compose, default folders will be created. Among it, |
|
The created |
|
To fix the wrong font size at the bottom, Calibri must be installed. See issue #30. |
I hope this setup is clearer, and explains a bit more into detail how to use the docker setup, and what motivates the design choices made. I've also tried to rectify the problem with what user owns the generated files. I'll need someone with an true linux environment (and not just a VM) to try it out in practise though
No need to keep this folder around since we can mount the templates from run/templates
|
So the changes I've done is :
I think we should leave #30 for another PR, and focus on solving docker related stuff here. |
After some input from others involved in this PR I descided it was probably best to leave the file owner problem as an optional solution, instead of forcing it upon users. I also clarified the docker readme even more, to hopefully explain why its designed as it is

Some pretty bare bones docker support, but for someone like me who likes running stuff via docker from the CLI, this works. We could probably improve it a lot in the future, by (somehow) caching the gradle dependencies in a separate step, and maybe providing a docker-compose file for easier volume mounting. But this is at least a start.