Skip to content

Bump version to 4.0.0-rc1 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renecannao merged 1 commit into from
Mar 23, 2026
Merged

Bump version to 4.0.0-rc1 #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.6
4.0.0-rc1
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Changing the version to a pre-release format like 4.0.0-rc1 will break the bump_release_version_and_tag script. This script is not designed to handle non-numeric patch segments and will fail when it tries to parse and increment the version.

Specifically, these lines in bump_release_version_and_tag will cause an error:

last_digit=$(echo "$old_version" | sed -e 's/.*\.//')
new_digit=$(($last_digit + 1))

With old_version as 4.0.0-rc1, last_digit becomes 0-rc1, which is not a valid integer for the arithmetic operation, causing the script to fail.

To avoid issues with future automated version bumps, please consider updating the script to correctly handle pre-release and other semantic versioning formats.

Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting RELEASE_VERSION to a non-numeric prerelease string (4.0.0-rc1) breaks the existing bump_release_version_and_tag helper script, which assumes x.y.z and does arithmetic on the last dot-separated component. If this script is still expected to be usable during RC cycles, update it to either (a) support prerelease versions, or (b) detect prerelease values and exit with a clear message telling the user to bump manually.

Suggested change
4.0.0-rc1
4.0.0

Copilot uses AI. Check for mistakes.
Loading