Conversation
ethernet8023
approved these changes
Mar 16, 2026
Contributor
ethernet8023
left a comment
ethernet8023
left a comment
There was a problem hiding this comment.
approved with an Ok from Jeff - we should see about making sure checkpoints save and load from this format as well, and maybe throw an error if we try and load a checkpoint at any step other than 0 that's in any format other than fp16. thoughts?
ethernet8023
approved these changes
Mar 20, 2026
Contributor
ethernet8023
left a comment
ethernet8023
left a comment
There was a problem hiding this comment.
i can't follow the barrer logic but it looks the same as the other methods, so lgtm.
IAvecilla
force-pushed
the
bf16-p2p-transfer
branch
from
58f1397 to
f4a68bc
Compare
IAvecilla
force-pushed
the
bf16-p2p-transfer
branch
from
f4a68bc to
3ffdced
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.