Open
Conversation
Contributor
|
@PuloV Looks like too large of a change just to support serializing to JSON. Beyond code clutter - replacing the getters/setters with callbacks seems to be overkill. I also don't think it should be the responsibility of ics-golang to handle serializing event data. If someone wants to do that - they can create their own event struct to do that. What if a user of the library does not want to use the json-tags specified? Now this is being forced on them. Recommend you close this one out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide json-marshaling for the event struct, i've removed all the getter and setter and set all attributes of event public.
Add also json-tags to event.