Merged
Conversation
|
@Dannyswiss1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Dannyswiss1
force-pushed
the
time-locked-release-INV
branch
from
8b03133 to
eda7e73
Compare
Contributor
Author
Contributor
|
@Dannyswiss1 please fix workflow |
Contributor
Author
|
hey @Cedarich please review |
Cedarich
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #156
This PR addresses the time-locking logic within the
escrow.rsmodule to ensure funds cannot be released before their designatedexpires_attimestamp under any circumstances.The primary focus is to solidify the core invariants governing escrow expiry, withdrawal, and refund, and thoroughly validating them with property-based ("fuzz") tests.