Skip to content

Fix NaN-unsafe vmax computation in log-scale LogNorm #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix NaN-unsafe vmax computation in log-scale LogNorm #237

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b9c2e
Initial plan
Copilot Mar 17, 2026
ee3c187
Fix NaN handling in log-scale norm: use np.nanmax instead of clipped.…
Copilot Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autoarray/plot/plots/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def plot_array(
log10_min = 1.0e-4

clipped = np.clip(array, log10_min, None)
norm = LogNorm(vmin=vmin or log10_min, vmax=vmax or clipped.max())
norm = LogNorm(vmin=vmin or log10_min, vmax=vmax or np.nanmax(clipped))
elif vmin is not None or vmax is not None:
norm = Normalize(vmin=vmin, vmax=vmax)
else:
Expand Down