Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy code that manually deletes checkpoint files for Nautilus and Dynesty searches and completely eliminates the nuclear mode functionality that is no longer used.
- Removed checkpoint file deletion if statements from Nautilus and Dynesty search modules
- Eliminated nuclear mode logic from abstract search, paths, and grid search modules
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| autofit/non_linear/search/nest/nautilus/search.py | Removed explicit checkpoint file removal |
| autofit/non_linear/search/nest/dynesty/search/abstract.py | Removed try block checking for checkpoint file removal |
| autofit/non_linear/search/abstract_search.py | Removed bypass_nuclear_if_on parameter and nuclear mode calls in post-fit handling |
| autofit/non_linear/paths/abstract.py | Removed nuclear mode deletion helper |
| autofit/non_linear/grid/grid_search/job.py | Adjusted job call to remove nuclear mode parameter |
| autofit/non_linear/grid/grid_search/init.py | Removed nuclear mode removal from metadata saving |
Collaborator
Author
|
The final push puts the if statements deleting checkpoint files back in, but now does so in the I remembered that these if loops were used to delete checkpoint files that were a duplicate of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes legacy code that manually deletes checkpoint files for Nautilus and Dynesty searches and completely eliminates the nuclear mode functionality that is no longer used.