Skip to content

Feature/checkpoint deleting#1124

Merged
Jammy2211 merged 6 commits intomainfrom
feature/checkpoint_deleting
Apr 2, 2025
Merged

Feature/checkpoint deleting#1124
Jammy2211 merged 6 commits intomainfrom
feature/checkpoint_deleting

Conversation

@Jammy2211
Copy link
Copy Markdown
Collaborator

@Jammy2211 Jammy2211 commented Mar 28, 2025

This PR removes legacy code that manually deletes checkpoint files for Nautilus and Dynesty searches and completely eliminates the nuclear mode functionality that is no longer used.

  • Removed checkpoint file deletion if statements from Nautilus and Dynesty search modules
  • Eliminated nuclear mode logic from abstract search, paths, and grid search modules

@Jammy2211 Jammy2211 requested review from Copilot and rhayes777 March 28, 2025 18:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes legacy code that manually deletes checkpoint files for Nautilus and Dynesty searches and completely eliminates the nuclear mode functionality that is no longer used.

  • Removed checkpoint file deletion if statements from Nautilus and Dynesty search modules
  • Eliminated nuclear mode logic from abstract search, paths, and grid search modules

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
autofit/non_linear/search/nest/nautilus/search.py Removed explicit checkpoint file removal
autofit/non_linear/search/nest/dynesty/search/abstract.py Removed try block checking for checkpoint file removal
autofit/non_linear/search/abstract_search.py Removed bypass_nuclear_if_on parameter and nuclear mode calls in post-fit handling
autofit/non_linear/paths/abstract.py Removed nuclear mode deletion helper
autofit/non_linear/grid/grid_search/job.py Adjusted job call to remove nuclear mode parameter
autofit/non_linear/grid/grid_search/init.py Removed nuclear mode removal from metadata saving

@Jammy2211
Copy link
Copy Markdown
Collaborator Author

The final push puts the if statements deleting checkpoint files back in, but now does so in the output_search_internal function.

I remembered that these if loops were used to delete checkpoint files that were a duplicate of the search_internal.dill file that normalizes the search. Putting them where they now are fixes the bug but retains the expected behaviour.

@Jammy2211 Jammy2211 merged commit 24fdafa into main Apr 2, 2025
4 checks passed
@Jammy2211 Jammy2211 deleted the feature/checkpoint_deleting branch April 30, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants